strict elemental setup #2201
Open
strict elemental setup #2201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
frelon
commented
Oct 2, 2024
frelon
commented
- Use --strict flag in elemental-setup services
- Set SilenceUsage for run-stage command
The default behavior has been to hide any errors and only log warnings. Using the --strict flag will ensure any yip errors are actually reported. Signed-off-by: Fredrik Lönnegren <[email protected]>
This ensures we do not show the usage text for errors caught during yip execution. Signed-off-by: Fredrik Lönnegren <[email protected]>
frelon
force-pushed
the
strict-elemental-setup
branch
from
196c69c
to
e10fd8a
Compare
davidcassany
reviewed
Oct 3, 2024
There was a problem hiding this comment.
Would be nice having some integration tests for that. What about setting some cloud-config in installation tests we know it will fail, so that we can check it still boots but on a degraded state, as some elemental-setup-* service failed. Even more, ideally we should be capable to see the failure in journalctl.
Alternatively, we also use such a process for the fallback test. Imagine we set a health check test that reports error if systemd is on degraded state.
Essentially, we should define the behavior we expect on a cloud-config failure and then add an integration tests to exercise it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.